fix: correct InspectGuest interface and remove render crash#90
Merged
Conversation
- Updated InspectGuest to match actual API response (added missing fields, removed non-existent meta field) - Removed Notes row that referenced meta.comment (not in API response) - Added null guard on checkInTime before formatting Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InspectGuestinterface to accurately reflect the API response (addedid,eventId,eventDate,eventStatus; madecreatedReasonoptional; typedcheckInTimeasstring | null)meta: { comment?: string }from the interface and destructuring (not returned by the API)meta?.commentcheckInTimenull guard before callingformat(new Date(checkInTime), ...)Why
The Inspect page crashed on every QR scan. Root cause:
metaandcreatedwere declared in the interface butmetawas never returned by the API, someta?.commentsilently rendered nothing — butcreatedbeing absent meantformat(new Date(undefined))threw during render, propagating past the.catch()and hitting the ErrorBoundary.Depends on mustachebash/api#121 which adds
createdto the/v1/inspectresponse.Test plan
npm testpasses inadmin/🤖 Generated with Claude Code